-
Notifications
You must be signed in to change notification settings - Fork 362
Feature: Relay safe apps sdk getBySafeTxHash api request #2361
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
[warning] @typescript-eslint/explicit-module-boundary-types
Report generated by eslint-plus-action |
src/components/AppLayout/Header/components/ProviderDetails/UserDetails.tsx
Outdated
Show resolved
Hide resolved
@francovenica this is ready for the QA. The ticket is on SDK repo so can't move it to the QA column :( |
Some clarification. I'll assume is Transaction hash Tried with the tx 994 from this safe: https://pr2361--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x9913B9180C20C6b0F21B6480c84422F6ebc4B808/transactions and this tx hash: The only value that I see wrong there (that I could confirm) is the nonce. The response says it is 0x2a6 (which is 678) while the safe says it is 994 @mikheevm can you check why the discrepancy there? |
@francovenica For me, it's the other way around. I think you might be using the old version of the safe-test-app, could you please check you have the latest changes? |
I see you were using the wrong input field. You need to use the one from the screenshot |
I'm the smartest man in the world. Never updated the repo in my computer, so I didn't had that field :D . I'll update it and check it later. Sorry for the mess |
Yes, there it is. Looks good to me Tested here. tx 994 |
What it solves
Relaying transaction details API call from the SDK, some type enhancements needed for safe-global/safe-apps-sdk#104
How this PR fixes it
Adds a handler for the new message method
getTxBySafeTxHash
and a new API functionHow to test it